Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rust-based generation and add additional message types #20

Merged
merged 52 commits into from
Jul 8, 2024

Conversation

jpbusch
Copy link
Collaborator

@jpbusch jpbusch commented Jun 17, 2024

Change default code-generation from py to rust

  • py code-generation is replaced by rust-based one (CI, vscode launch config and README)
  • py code-generation files are still located in codegen-py

Updates CAM and DENM

  • CAM and DENM c-code, msgs and conversion headers are regenerated using the rust-codegen
  • this leads to small changes in these generated files, including license updates, line breaks and some small naming changes, because of camel-case / snake-case conversion (example diff)

CPM v2.1.1

  • generate c-code / msgs / conversion headers for CPM as a new message type
  • add publish_cpm.py to generate a dummy CPM ROS message
  • currently there are no access functions implemented for the CPM

@jpbusch
Copy link
Collaborator Author

jpbusch commented Jul 1, 2024

We were able to generate and compile the ROS msgs and conversion headers for the CPM. The conversion node is now also able to convert CPMs. Feel free to try out this branch with your use cases. This would help us to validate.

@riebl, @v0-e, @Foxei, @lheg

@joaomiguelpereiradealmeida

We were able to generate and compile the ROS msgs and conversion headers for the CPM. The conversion node is now also able to convert CPMs. Feel free to try out this branch with your use cases. This would help us to validate.

@riebl, @v0-e, @Foxei, @lheg

Dear @jpbusch , thank you very much for the CPM integration. Since CPMs use CDD Release 2, it would be great if we can also have the CAM and DENM Release 2 available to test the 3 types of messages together. Do you think they could be integrated in this PR?

@jpbusch
Copy link
Collaborator Author

jpbusch commented Jul 5, 2024

Hi @joaomiguelpereiradealmeida! We have decided to only add the CPM with this PR for now. We then want to add a second branch in this repo, on which we will also upgrade CAM and DENM to release2.
Outcome after first tests: The CAM release2 should work quite straight forward, but there will still be a few problems with the DENM release2.

@joaomiguelpereiradealmeida

Hi @joaomiguelpereiradealmeida! We have decided to only add the CPM with this PR for now. We then want to add a second branch in this repo, on which we will also upgrade CAM and DENM to release2. Outcome after first tests: The CAM release2 should work quite straight forward, but there will still be a few problems with the DENM release2.

Great, thank you @jpbusch. Just a note, I would say that maybe it could be useful to have message conversion from both releases available simultaneously, since in a real-world scenario we are going to have co-existence of vehicles transmitting messages from different releases. So, maybe having different folders on the same branch, e.g. for CAM_r1 and CAM_r2, could work?

@jpbusch jpbusch merged commit 9372249 into main Jul 8, 2024
11 of 15 checks passed
@jpbusch jpbusch deleted the further-msgs branch July 8, 2024 15:17
This was referenced Jul 8, 2024
lreiher added a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants