Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characteristic improvements #73

Merged
merged 11 commits into from
Apr 6, 2018
Merged

Characteristic improvements #73

merged 11 commits into from
Apr 6, 2018

Commits on Mar 30, 2018

  1. Merged set_value and get_hap_value 

    * Small improvements
* Added helper method '_validate_value'
* Added helper method '_get_default_value'
* Raise ValueError if properties are invalid
* Added __slots__
    @cdce8p
    cdce8p committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    e555607 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. Additional changes 

    * New method: update_value (use for value updates from HAP-python)
* Rename: to_HAP to to_dict
* New method: from_dict (use during loading of chars)
    @cdce8p
    cdce8p committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    78f6758 View commit details
    Browse the repository at this point in the history

  2. Addressed comments 

    * Fixed errors, small mistakes
    @cdce8p
    cdce8p committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    2505401 View commit details
    Browse the repository at this point in the history

  3. Added debug statements

    @cdce8p
    cdce8p committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    b25f052 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2018

  1. Changed '_LOGGER' to 'logger'

    @cdce8p
    cdce8p committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    9c26ce3 View commit details
    Browse the repository at this point in the history

  2. Changed raise error to return None

    @cdce8p
    cdce8p committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    9269b42 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. Raising ValueErrors with custom msg

    @cdce8p
    cdce8p committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    4bcf00c View commit details
    Browse the repository at this point in the history

  2. Bugfix, added additional logger.error statements

    @cdce8p
    cdce8p committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    2dafa0f View commit details
    Browse the repository at this point in the history

  3. Rearanged functions

    @cdce8p
    cdce8p committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    79de11f View commit details
    Browse the repository at this point in the history

  4. Added error_msg parameter

    @cdce8p
    cdce8p committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    1d94c34 View commit details
    Browse the repository at this point in the history

  5. Added tests 

    * Added '/htmlcov' to .gitignore
    @cdce8p
    cdce8p committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    228d9f8 View commit details
    Browse the repository at this point in the history