-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add working examples #299
Comments
I wish to refactor the # Current
sample
├── _example
│ ├── db_search
│ │ └── main.go
│ ├── go.mod
│ ├── go.sum
│ ├── tokenize
│ │ └── main.go
│ └── wakati
│ └── main.go
├── dict
│ └── userdict.txt
└── wasm
├── README.md
├── go.mod
├── kagome.html
└── main.go # After refactor
_example
├── go.mod
├── go.sum
│
├── dict
│ └── userdict.txt
├── db_search
│ └── main.go
├── tokenize
│ └── main.go
├── wakati
│ └── main.go
└── wasm
├── README.md
├── kagome.html
└── main.go |
Thanks for the suggestion. I had the current directory structure so as not to change the location of the sample user dictionary, but I thought it would be a good idea to change it. I thought it would be better to put go.mod in each subdirectory. What do you think? # After refactor
_example
│
├── dict (or user_dict)
│ └── userdict.txt
├── db_search
│ ├── go.mod
│ ├── go.sum
│ └── main.go
├── tokenize
│ ├── go.mod
│ ├── go.sum
│ └── main.go
├── wakati
│ ├── go.mod
│ ├── go.sum
│ └── main.go
└── wasm
├── go.mod
├── go.sum
├── README.md
├── kagome.html
└── main.go |
I agree. Having In that case we need to place go.work file for multi-module to avoid warnings from IDE/gopls. # After refactor
_example
+├── go.work
│
-├── dict (or user_dict)
+├── user_dict
+│ ├── go.mod
+│ ├── go.sum
+│ ├── main.go
│ └── userdict.txt
├── db_search
│ ├── go.mod
│ ├── go.sum
│ └── main.go
├── tokenize
│ ├── go.mod
│ ├── go.sum
│ └── main.go
├── wakati
│ ├── go.mod
│ ├── go.sum
│ └── main.go
└── wasm
├── go.mod
├── go.sum
├── README.md
├── kagome.html
└── main.go This allows users to simply change their working directory and run the examples. |
It seems to be good, looking forward to your pull request. Thank you! |
Refactor directory structure of examples. - related issue ikawaha#200 ikawaha#299 (comment)
see. #277 (comment)
The text was updated successfully, but these errors were encountered: