Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: fix page number and refers original sample code #317

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

hurutoriya
Copy link
Contributor

@hurutoriya hurutoriya commented Feb 21, 2024

What

Why

It is very interesting! Thank you for a good example

https://github.com/ikawaha/kagome/blob/v2/sample/_example/db_search/main.go

I found a some improvement points.

@hurutoriya hurutoriya changed the title update: fix page number update: fix page number and refers original sample code Feb 21, 2024
@ikawaha
Copy link
Owner

ikawaha commented Feb 21, 2024

Nice catch! Thank you!

@ikawaha ikawaha merged commit f315131 into ikawaha:v2 Feb 21, 2024
7 checks passed
@hurutoriya hurutoriya deleted the patch-1 branch February 21, 2024 15:38
@KEINOS
Copy link
Contributor

KEINOS commented Mar 3, 2024

Oops! The page number was from the e-book! I should have notice! (//∇//)
Thanks for the fix and the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants