Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add standard ja filter #339

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Conversation

ikawaha
Copy link
Owner

@ikawaha ikawaha commented Aug 3, 2024

To make commonly used Lucene Japanese filters more convenient to use, added built-in Japanese filters to the morphological analyzer.

@@ -0,0 +1,132 @@
package ja
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
package-comments: should have a package comment (revive)

return nil, fmt.Errorf("failed to load stop words: %w", err)
}
return &Filter{
baserForm: filter.NewPOSFilter(filter.POS{"動詞"}, filter.POS{"形容詞"}, filter.POS{"形容動詞"}),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
string literal contains rune in Han script (gosmopolitan)

@ikawaha ikawaha merged commit 426167d into develop Aug 3, 2024
7 checks passed
@ikawaha ikawaha deleted the feat/lucene-filter_20240803 branch August 3, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant