Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo in both controller->afterroute and view->render #5

Closed
doonge opened this issue Jan 18, 2015 · 2 comments
Closed

echo in both controller->afterroute and view->render #5

doonge opened this issue Jan 18, 2015 · 2 comments

Comments

@doonge
Copy link

doonge commented Jan 18, 2015

Hello,

it's not really a problem as everything works wonder, but I wonder why there is an echo in both the controllers->afterroute (which invokes view->render) and the views->render themselves (which return nothing, so the echo in the controller doesn't look useful).

The code does this:

in Controller->afterroute:
echo $this->response->render();

in View->render()
echo \Template::instance()->render($this->template);
(returns nothing)

Is this a safeguard for custom Views?
Best whishes.

@ikkez
Copy link
Owner

ikkez commented Jan 18, 2015

hi. yeah i guess one of it is superfluous. I guess there should be a return instead of echo in the View.
I'll fix this. thanks ;)

ikkez added a commit that referenced this issue Mar 8, 2015
@ikkez
Copy link
Owner

ikkez commented Mar 8, 2015

fixed

@ikkez ikkez closed this as completed Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants