fix get_uris() bug introduced at #91 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: Assume that file directory is equal to filename is a misconcept Checksum was getting bad values and this broke aria2 result: hang forever at "Working... this may take a while." Patch: Use package naming convection to extract version from package name. This patch relies on format: <name>_<version>_<arch>.deb solves introduced bug at ilikenwf#91 add initial support for filesize
|
Please @ilikenwf, merge it as soon as possible because I broke upstream. Eventually, a discussion for verify how md5 is being patched or move to a downloader with sha256 is mandatory. Alternatively, ask canonical to serve an apt-get --print-uris option that forces md5 is another way to avoid above workaround. |
ilikenwf
pushed a commit
that referenced
this pull request
Jan 29, 2016
…5-uris fix get_uris() bug introduced at #91
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix get_uris() bug introduced at #91
Rationale:
Assume that file directory is equal to filename is a misconcept
Checksum was getting bad values and this broke aria2
result: hang forever at "Working... this may take a while."
Patch:
Use package naming convection to extract version from package
name. This patch relies on format: .deb
solves introduced bug at #91
add initial support for filesize