Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Browserstack Testing #7961

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

jrjohnson
Copy link
Member

Couple of changes to hopefully make this better.

This browser is based on chromium now and we probably won't find
anything interesting in these tests. Removing them as we need to improve
our test run times on browserstack.
We're limited on the number of processes we can run in browserstack,
let's just one run at a time.
We don't pay for enough capacity to speed these up, running fewer of
them and less at the same time will help our throughput of all pull
requests.
@jrjohnson jrjohnson marked this pull request as ready for review July 12, 2024 22:03
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. top notch code comments too!

@stopfstedt stopfstedt merged commit 794afa5 into ilios:master Jul 12, 2024
35 checks passed
@jrjohnson jrjohnson deleted the browser-testing branch July 12, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants