Enable Testing with Ember Exam #7963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits the tests into chunks and launches a bunch of browsers to run them. I've defaulted this to 8 for running tests on a local machine, but only 3 for github where there are less cores available.
These oks are not testing anything, we wanted equal. For some reason this broke in ember-exam which I guess is a good thing.
Without this we need to define how many tests to split apart, adding this is needed to evenly split tests.
This makes it possible to reply the test order locally and will be very useful if we have any flaky tests.
stopfstedt
reviewed
Jul 15, 2024
| @@ -74,7 +74,7 @@ module('Integration | Component | learnergroup-selection-cohort-manager', functi | |||
| assert.expect(2); | |||
| this.set('filter', ''); | |||
| this.set('remove', (learnerGroup) => { | |||
| assert.ok(this.secondLevelLearnerGroup1, learnerGroup); | |||
| assert.deepEqual(this.secondLevelLearnerGroup1, learnerGroup); | |||
stopfstedt
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the tests into chunks and launches a bunch of browsers to run
them. I've defaulted this to 8 for running tests on a local machine, but
only 3 for github where there are less cores available.