Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with multiple percySnapshot calls in same test #7968

Conversation

michaelchadwick
Copy link
Contributor

@@ -0,0 +1,3 @@
export function getUniqueName(assert, description) {
return assert.test.module.name + ' | ' + assert.test.testName + ' | ' + description;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, very nice!

@stopfstedt stopfstedt removed their request for review July 16, 2024 15:20
@michaelchadwick michaelchadwick force-pushed the frontend-5586-duplicate-percysnapshot-fix branch from 3e61e6f to 11b1174 Compare July 16, 2024 17:52
@jrjohnson jrjohnson enabled auto-merge July 16, 2024 20:49
@jrjohnson jrjohnson merged commit b112879 into ilios:master Jul 16, 2024
37 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5586-duplicate-percysnapshot-fix branch July 16, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percy Snapshots Need Unique Names
2 participants