Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting XDXF articles from Stardict dictionaries to HTML #258

Closed
qnga opened this issue Oct 26, 2020 · 3 comments
Closed

Converting XDXF articles from Stardict dictionaries to HTML #258

qnga opened this issue Oct 26, 2020 · 3 comments
Labels

Comments

@qnga
Copy link

qnga commented Oct 26, 2020

Hello!

I had to convert to Slobs some Stardict dictionaries with type identifier "x", that is, whose articles are in the XDXF format, so I implemented this feature by adding a read option to the Stardict plugin and using xdxf_to_html_transformer.

This feature might also be a write option in the Slob plugin though. I suspect converting articles from XDXF to HTML is a generic feature that may be useful for several readers or writers. From an architectural point of view, it might be better modelled as an intermediate filter between readers and writers, but it might not be a trivial job and would be overkill if there's no additional need for such filters.

Let me know what you think about that and if you would be interested in a PR implementing this feature either in the Stardict reader, or in the Slob writer.

@ilius
Copy link
Owner

ilius commented Oct 26, 2020

I pushed to branch stardict-xdxf.
By default should convert to html.
Please test it and let me know.
Thanks

@ilius ilius added the Feature label Oct 26, 2020
@qnga
Copy link
Author

qnga commented Oct 26, 2020

Yes, that's fine and perfectly matches my own code. Thanks.

@ilius
Copy link
Owner

ilius commented Oct 26, 2020

I pushed to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants