Read xml file from goldbook.iupac.org

[dthirst]

Hi!

I tried converting an xml dictionary into stardict with the CLI, but get hit with this exception every time:

unhandled exception:
Traceback (most recent call last):
  File "/Users/USERNAME/src/pyglossary/pyglossary/ui/ui_cmd_interactive.py", line 1016, in run
    succeed = ui_cmd.UI.run(self, **self.getRunKeywordArgs())
  File "/Users/USERNAME/src/pyglossary/pyglossary/ui/ui_cmd.py", line 331, in run
    finalOutputFile = self.glos.convert(
  File "/Users/USERNAME/src/pyglossary/pyglossary/glossary.py", line 1323, in convert
    if not self.read(
  File "/Users/USERNAME/src/pyglossary/pyglossary/glossary.py", line 846, in read
    reader = self._createReader(format, options)
  File "/Users/USERNAME/src/pyglossary/pyglossary/glossary.py", line 733, in _createReader
    reader = self.plugins[format].readerClass(self)
  File "/Users/USERNAME/src/pyglossary/pyglossary/plugins/wiktionary_dump.py", line 38, in __init__
    self.compilePatterns()
  File "/Users/USERNAME/src/pyglossary/pyglossary/plugins/wiktionary_dump.py", line 121, in compilePatterns
    self._re_comment = re.compile(
TypeError: compile() takes from 1 to 2 positional arguments but 3 were given

Best,

[ilius]

What kind of XML dictionary?
There are several formats that use XML.
Is it for Wikimedia dumps?
Or Apple Dictionary source format?

[dthirst]

Thank you for your swift reply and attempt to fix the bug!
I honestly don't know what standard the file in question adheres to, I got it from here and they only state that it is in XML format: https://goldbook.iupac.org/
I pulled the commit you referenced, unfortunately I am met with another exception:

[INFO] Automatically switching to SQLite mode for writing Stardict
[INFO] fileSize = 7011746
unhandled exception:
Traceback (most recent call last):
  File "/Users/USERNAME/src/pyglossary/pyglossary/glossary.py", line 902, in _read
    reader.open(filename)
  File "/Users/USERNAME/src/pyglossary/pyglossary/plugins/wiktionary_dump.py", line 65, in open
    siteinfoBytes = self._readSiteInfo()
  File "/Users/USERNAME/src/pyglossary/pyglossary/plugins/wiktionary_dump.py", line 49, in _readSiteInfo
    siteinfoBytes = self._buff + b"</siteinfo>"
TypeError: unsupported operand type(s) for +: 'NoneType' and 'bytes'

[CRITICAL] Reading file '/Users/demian/Downloads/goldbook_vocab.xml' failed.

[ilius]

This format is not supported.

[dthirst]

I understand, thank you.

[ilius]

I added support.
If using command line, you need to pass --read-format IUPACGoldbook.