Improve Python typing in dsl plugin #489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a gentle and encouraging ping at this thread, I decided to take a look at how my old rusty code is doin'.
Needless to say, there's a lot of room for improvements — considering a jump from Python 2.7 at that time to 3.9+ nowadays.
Also, @ilius are you sure those
self: "typing.Self"
are really worth putting everywhere? I don't feel like they bring much value, and they cost a lot of visual noise. Actually, I've never seen these kind of hints.