Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_naturally_exhaustive test for usize/isize. #116

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Fix is_naturally_exhaustive test for usize/isize. #116

merged 2 commits into from
Apr 15, 2023

Conversation

fshaked
Copy link
Contributor

@fshaked fshaked commented Apr 14, 2023

Always return false in those cases (as is the case for u32, i32, u64, and i64).

Without this, FromPrimitive is not usable with repr(usize).

@fshaked
Fix is_naturally_exhaustive test for usize/isize.
dba672f 
Always return false in those cases (as is the case for u64/i64).
illicitonion
illicitonion approved these changes Apr 15, 2023
View reviewed changes
Copy link
Owner

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit f1ee727 into illicitonion:main Apr 15, 2023
@illicitonion
Copy link
Owner

This was released in 0.6.1 - thanks so much for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fshaked @illicitonion