Merge main into y1_production #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fluid module with resident vel grad function. * Update fluid.py * Update test_fluid.py * Reflect func name change in docstring * Update copyright statements. Co-authored-by: Matt Smith <mjsmith6@illinois.edu> * Correct structure of returned object for local grad, improve the expression. Co-authored-by: Matt Smith <mjsmith6@illinois.edu> * Correct dv expression, add return structure example. * Bring back expression closer to @majosm suggestion. * Refactor sanity check per @majosm review, add exact comparison for eoc test. * Apply @majosm review suggestions. Co-authored-by: Matt Smith <mjsmith6@illinois.edu> * Add note about product rule. * Fix doc cosmetic. * Clean up docs * Update grad(v) to be like what is used in NS (#298) * Clean up docs a bit. * Update test to reflect not taking gradients inside velgrad function * Revert "Update test to reflect not taking gradients inside velgrad function" This reverts commit 7460dfd. * Replace print with logger. * Move ConservedVars to fluid module. (#273) Co-authored-by: Matt Smith <mjsmith6@illinois.edu> Co-authored-by: Matt Smith <mjsmith6@illinois.edu>
…rnal alpha) (#297) Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Matt Smith <mjsmith6@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes illinois-ceesd/timing#11