Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Refactor: Linter Warnings Fix #58

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Refactor: Linter Warnings Fix #58

merged 1 commit into from
Mar 25, 2019

Conversation

ayushr2
Copy link
Contributor

@ayushr2 ayushr2 commented Mar 23, 2019

  • Fixed all shadowing issues
  • Fixed all type mismatch warnings

@ayushr2 ayushr2 requested a review from nmagerko March 23, 2019 08:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 351

  • 31 of 31 (100.0%) changed or added relevant lines in 14 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 89.37%
Files with Coverage Reduction New Missed Lines %
broadway_api/daos/grading_job.py 1 94.74%
Totals Coverage Status
Change from base Build 349: 0.03%
Covered Lines: 681
Relevant Lines: 762
💛 - Coveralls

nmagerko
nmagerko approved these changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@nmagerko nmagerko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but we should probably make sure that the CI prevents these warnings from making it into master in the first place.

@ayushr2
Copy link
Contributor Author

ayushr2 commented Mar 24, 2019

flake8 does not seem to catch the above-mentioned issues. We could try pychecker

@ayushr2
Copy link
Contributor Author

ayushr2 commented Mar 25, 2019

pychecker is only for python2. Have created an issue about this #59. Merging this for now.

@ayushr2 ayushr2 merged commit 91e85dc into master Mar 25, 2019
@ayushr2 ayushr2 deleted the refactor/fix-warnings branch March 25, 2019 19:31
@ayushr2 ayushr2 mentioned this pull request Sep 29, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmagerko nmagerko nmagerko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushr2 @coveralls @nmagerko