Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for dark mode #276

Merged
merged 12 commits into from
Apr 17, 2019
Merged

Tweaks for dark mode #276

merged 12 commits into from
Apr 17, 2019

Conversation

nwalters512
Copy link
Member

This started out as simply a fix to the error page styles (which had some hardcoded colors) but ended up containing a bunch of little refinements:

  • Add a page of documentation to dark mode (how it works + emphasis on making sure new features play nicely with it)
  • Persist state in a cookie so that we can SSR with/without dark mode styles as appropriate
  • Adjust placement of dark mode toggle in the navbar
  • Make login page dark mode compatible
  • Adjust naming of properties in the theme context
  • Changes the "settings" button on queue cards to a gear icon (looks better in general, but especially in dark mode)

@vercel
Copy link

vercel bot commented Apr 17, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot temporarily deployed to staging April 17, 2019 02:04 Inactive
Copy link
Member

@james9909 james9909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nwalters512 nwalters512 merged commit 99b2690 into master Apr 17, 2019
@nwalters512 nwalters512 deleted the fix-error-page-darkmode branch April 17, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants