Fix: Autocomplete turned off for Staff #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rop to bounce back uidInput value
… dispatcher logic
…t-no-autocomplete Feature/autocomplete staff list no autocomplete
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/illinois/queue/tecrvxdpig |
andrewstec
commented
Mar 25, 2020
| } | ||
|
|
||
| // We want to exclude existing staff from the autocompletion list | ||
| const filterBy = option => { | ||
| return props.existingStaff.findIndex(user => user === option.id) === -1 | ||
| return props.existingStaff.findIndex(u => u === option.id) === -1 |
There was a problem hiding this comment.
Changed because user already declared in upper scope.
jackieo5023
approved these changes
Apr 29, 2020
|
Any time! Thanks for accepting the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: A staff user would attempt to add another staff user and experience a permissions error where an Autocomplete component would attempt to fetch user information that the staff role should not have access to. It rightly resulted in a back-end error being received by the user on the front-end UI.
Fix: Enable autocorrect for the admin user role, but only allow manual entries for the staff user role.
Original issue filed here: #305