Added the logic in queue.js to show the queue name and location

[sgorse]

No description provided.

[nwalters512]

Thanks Shirdon! Take a look at my feedback, and also please fix the linter errors that Travis is reporting. Last step would be to get up-to-date with master and add a changelog entry.

[nwalters512]

Should be named queue for consistency with the rest of the application.

[nwalters512]

queueInfo might not be defined while the page is still loading (try refreshing the queue page with your code as-is). Avoid accessing any properties until after the various isFetching checks.

[nwalters512]

Remove extraneous log.

[nwalters512]

Try splitting into two lines, maybe with a combination of <h3>/<h5 className="text-muted">, would look even better with the location icon that's used on the queue cards on the homepage!

[sgorse]

I am having an issue fixing one of the linter errors. The initial error is " 'queue' is missing in props validation". When I try an add "queue: Proptypes.object.isRequired," to Queue.propTypes, it tells me that the Prop type object is forbidden. How can I add queue to the proptypes if its type is forbidden?

[nwalters512]

You should use PropTypes.shape instead, take a look at the course prop on the course page.

[sgorse]

Ok, thanks for pointing that out. I am still getting a warning on the client console for the queue.id. I am getting this warning along with other warnings that do not pertain to the queue. The one that does is "Warning: Failed prop type: Invalid prop queue.id of type number supplied to Queue, expected object". Am I not setting the queue.id propType properly here?

Queue.propTypes = {
  isFetching: PropTypes.bool.isRequired,
  hasQueue: PropTypes.bool.isRequired,
  fetchQueue: PropTypes.func.isRequired,
  queueId: PropTypes.number.isRequired,
  dispatch: PropTypes.func.isRequired,
  queue: PropTypes.objectOf(
    PropTypes.shape({
      id: PropTypes.number,
      name: PropTypes.string,
      location: PropTypes.location,
    })
  ),
}

[sgorse]

Warning: Failed prop type: The prop descText is marked as required in ConfirmLeaveQueueModal, but its value is undefined.

main.js:4542 Warning: Failed prop type: The prop confirmText is marked as required in ConfirmLeaveQueueModal, but its value is undefined.

These were the other two warnings, but I don't think queue.js should have an effect on them

[nwalters512]

You don't need the objectOf part, that's only if you have an object whose values are all queues. Just shape is enough. The other bit is not related to you: #79

[nwalters512]

Can you add a bottom margin here? Maybe mb-4.

[sgorse]

         <Col
            xs={{ size: 12 }}
            md={{ size: 4 }}
            lg={{ size: 3 }}
            className="mb-3"
          >
            <h3>{this.props.queue.name}</h3>
            <h5 className="text-muted">
              <FontAwesomeIcon icon={faMapMarker} fixedWidth className="mr-2" />
              {locationText}
            </h5>
          </Col>

Would this be how I add the bottom margin?

[nwalters512]

You can just add it directly to the h5