Handle API errors correctly #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/queues.js
Outdated
| @@ -49,7 +53,7 @@ router.post( | |||
| ]), | |||
| failIfErrors, | |||
| ], | |||
| (req, res, _next) => { | |||
| (req, res, next) => { | |||
There was a problem hiding this comment.
is there a reason this was changed from _next to next?
There was a problem hiding this comment.
The underscore was used to indicate an unused param, but it's actually used now.
api/queues.js
Outdated
| queue | ||
| .save() | ||
| .then(newQueue => res.status(201).json(newQueue)) | ||
| .catch(next) |
There was a problem hiding this comment.
why is this post catching instead of using the wrapper?
There was a problem hiding this comment.
The wrapper is really only for async stuff, this is using promises directly so it's better to use catch directly.
genevievehelsel
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps all route handlers with a function that will catch any errors and send them through
express.