This repository has been archived by the owner on Jun 8, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@illuusio I think you're right about wrapping the context calls with locks. thread-mainloop.h says:
And then goes on to discuss locking:
It also explictly says that the lock must be held when calling pa_threaded_mainloop_wait. So this means all the stuff in PaPulseAudio_Initialize does need to happen while locked, therefore I've reinstated the locks that were removed in 207937b (actually I just hold the lock for the whole time we are doing pulse stuff). The only other place I could find making a pulse call without the lock held was Terminate.