Fix issue #36: Anagram check #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iluwatar please review this. |
iluwatar
requested changes
Nov 8, 2019
README.md
Outdated
| var l1 = s1.length(); | ||
| var l2 = s2.length(); | ||
| int [] arr1 = new int[256]; | ||
| int [] arr2 = new int[256]; |
There was a problem hiding this comment.
$ jshell
| Welcome to JShell -- Version 11.0.4
| For an introduction type: /help intro
jshell> var arr1 = new int[256];
arr1 ==> int[256] { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ... , 0, 0, 0, 0, 0, 0, 0, 0 }
There was a problem hiding this comment.
Thanks for the information. Fixed 😄
iluwatar
approved these changes
Nov 8, 2019
|
Excellent @PalAditya, thank you very much for this snippet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Note: Apparently var in arrays is not allowed, so I used int declaration there, although I couldn't find these behavior in the docs 🤔