Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce vertical split mode for executors #197

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

ilyachur
Copy link
Owner

Introduce 2 new options:

  • g:cmake_build_executor_split_mode - allows to change default mode and open CMake windows in vertical mode. (Available values: 'sp' - horizontal mode, 'vsp' - vertical mode).
  • g:cmake_build_executor_window_size - replaces the variable g:cmake_build_executor_height defines the size of executor window.

Option g:cmake_build_executor_height was deprecated and will be removed at the end of April 2024.

@ilyachur ilyachur linked an issue Feb 19, 2024 that may be closed by this pull request
autoload/cmake4vim.vim Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79692cf) 98.5% compared to head (88dd3fb) 98.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #197   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files          19      19           
  Lines        1283    1291    +8     
======================================
+ Hits         1264    1272    +8     
  Misses         19      19           
Files Coverage Δ
autoload/cmake4vim.vim 99.5% <100.0%> (+<0.1%) ⬆️
autoload/utils/common.vim 98.7% <100.0%> (+0.1%) ⬆️
autoload/utils/exec/job.vim 98.6% <100.0%> (ø)
autoload/utils/exec/system.vim 100.0% <100.0%> (ø)
autoload/utils/exec/term.vim 98.3% <100.0%> (+<0.1%) ⬆️
autoload/utils/window.vim 98.2% <100.0%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79692cf...88dd3fb. Read the comment docs.

@ilyachur ilyachur merged commit 52048fe into master Feb 20, 2024
18 checks passed
@ilyachur ilyachur deleted the introduce_vertical_split_mode branch February 20, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possiblity to change cmake_build_executor split to vertical split
1 participant