Create Major Tag #29
Closed
Create Major Tag #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradyclifford
commented
Feb 6, 2023
| @@ -66,3 +67,10 @@ jobs: | |||
| else | |||
| echo "There were no changes to commit" | |||
| fi | |||
|
|
|||
| - name: Upload dist folder as artifact on commit failure | |||
There was a problem hiding this comment.
This helps with those using forks to manually upload the correct dist changes produced.
|
Due to forking issues, #28 was created instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR changes
Allow the creation of a major tag adjacent to the normal major + minor + patch tag creation.
This allows downstream workflows to reference the major version instead of the specific minor + patch. Doing so will reduce dependabot alerts and unnecessary PRs to get the latest major version.
This a common pattern used by the mainstream GitHub Actions, including those we already use in this repo:
https://github.com/actions/toolkit/blob/main/docs/action-versioning.md#recommendations
As an example, release
v1.2.3is created with an accompanyingv1tag. Downstream consumers of this repo can referencev1instead ofv1.2.3.PR Requirements
+semver:keywords.NOTE: If the repo's workflow could not automatically update the
README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.