Fix WebP decoding #1823
Merged
Fix WebP decoding #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks plausible, but I'm not really familiar with the WebP format. Any chance you could add a test or two? |
|
Sure. I have an animated WebP that failed before this patch. I'll add a test that ensures that decoding it doesn't panic. |
|
Well, the test I added revealed another issue with the WebP decoder. I guess I'll fix that as well in this PR. |
|
Specifically, this code: https://github.com/image-rs/image/blob/master/src/codecs/webp/extended.rs#L83-L89 is wrong. It should check the color type of the first frame from the actual image data. |
|
Fixed |
HeroicKatora
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.