Only accept .ff as path extension for Farbfeld #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Is ".farbfeld" actually an accepted file extension for the format? I tried finding references online, but both this wiki page and the Ubuntu man pages both just mention ".ff". The main page doesn't even indicate a file format |
|
That's a valid question. I've not seen .farbfeld completely written out as an extension outside this library. Usually, the header or .ff extension is used. |
|
In that case, could you instead change from_extension to only support ".ff"? |
This is consistent with ImageFormat::extensions_str, and usage by other image libraries and tools.
foresterre
force-pushed
the
consistent-extensions-farbfeld
branch
from
0768024
to
2c29900
Compare
|
Certainly! (Whoops pressed the wrong button) |
foresterre
changed the title
foresterre
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only accepts .ff as path extension for Farbfeld
This is consistent with ImageFormat::extensions_str, and usage by other image libraries and tools.