Implemented incremental png loading #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birktj
force-pushed
the
incremental_png_loading
branch
from
2d2838d
to
2173f03
Compare
|
@fintelia or @HeroicKatora could you have a look at this? |
This was referenced Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an incremental reader to the png type. The reader uses
png::Reader::next_rowto try to decode the png one row at a time.This is a small breaking api change as
PNGDecoder::Readernow becomesPNGReader.There should probably be some new tests to check the reader with different buffers ect... but I am not entirely sure where they should go?
Related to #858