Add delta parameter to adaptive_threshold
#637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripytide
reviewed
May 22, 2024
ripytide
reviewed
May 22, 2024
|
Thanks! I think it would be better to just add the delta parameter to the existing function - it’s a breaking change but a trivial one for users to deal with. |
Dantsz
changed the title
adaptive_threshold_with_deltadelta parameter to adaptive_threshold
|
We run nightly clippy and it looks like you’ve fallen foul of a newly added lint triggering on old code. However, the fix it recommends is trivial so please can you make the edit suggested and then I’ll merge this PR. Thanks for the PR :-) |
Co-authored-by: ripytide <62516857+ripytide@users.noreply.github.com>
Dantsz
force-pushed
the
adaptive_threshold_with_delta
branch
from
4477632
to
d37e988
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #532
The opencv implementation seems to take the delta as float and rounds it differently based on if the thresholding is inverted or not, we don't have an inverted mode for this so passing delta as
i32should be fine.