Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect legacy commands to the ImageJ UI #207

Merged
merged 2 commits into from
May 5, 2023

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented May 3, 2023

As we found out in #205, there are too many edge cases when we try to run original ImageJ PlugIns within napari. So let's instead make it as easy as possible to open up the ImageJ UI, and simultaneously prevent users from executing them within napari.

I do like that we maintain them in the search window, though, as otherwise people might not realize that all of this functionality is available.

@gselzer gselzer added the enhancement New feature or request label May 3, 2023
@gselzer gselzer requested review from ctrueden and hinerm May 3, 2023 17:24
@gselzer gselzer self-assigned this May 3, 2023
@gselzer gselzer marked this pull request as draft May 3, 2023 17:24
@gselzer gselzer force-pushed the disable-original-imagej-commands-in-napari branch 2 times, most recently from a146faf to 2b23631 Compare May 3, 2023 17:41
@gselzer
Copy link
Collaborator Author

gselzer commented May 3, 2023

TODO: Test legacy commands divert to ImageJ UI

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Patch coverage: 57.57% and project coverage change: -0.26 ⚠️

Comparison is base (3b31818) 89.62% compared to head (e9c40e0) 89.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   89.62%   89.36%   -0.26%     
==========================================
  Files          48       48              
  Lines        4394     4456      +62     
==========================================
+ Hits         3938     3982      +44     
- Misses        456      474      +18     
Impacted Files Coverage Δ
src/napari_imagej/widgets/result_runner.py 90.00% <ø> (ø)
src/napari_imagej/widgets/menu.py 76.42% <40.57%> (-1.45%) ⬇️
tests/widgets/test_menu.py 71.81% <65.85%> (-0.04%) ⬇️
src/napari_imagej/java.py 80.65% <87.50%> (-0.84%) ⬇️
src/napari_imagej/widgets/result_tree.py 91.66% <100.00%> (ø)
src/napari_imagej/widgets/widget_utils.py 91.89% <100.00%> (+1.56%) ⬆️
tests/utils.py 95.85% <100.00%> (+0.10%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gselzer gselzer force-pushed the disable-original-imagej-commands-in-napari branch 3 times, most recently from a5aa44f to 854c0e3 Compare May 5, 2023 15:39
@gselzer gselzer force-pushed the disable-original-imagej-commands-in-napari branch from 854c0e3 to ecdd5e4 Compare May 5, 2023 16:41
@gselzer gselzer marked this pull request as ready for review May 5, 2023 17:03
@gselzer gselzer force-pushed the disable-original-imagej-commands-in-napari branch from 7575a45 to e9c40e0 Compare May 5, 2023 19:39
@gselzer gselzer merged commit facf948 into main May 5, 2023
@ctrueden ctrueden deleted the disable-original-imagej-commands-in-napari branch May 19, 2023 20:27
kephale pushed a commit to kephale/napari-imagej that referenced this pull request May 24, 2023
…mands-in-napari

Redirect legacy commands to the ImageJ UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants