Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #36 and cypress e2e tests for lazy loading and lqip #40

Conversation

eco-line
Copy link
Contributor

@eco-line eco-line commented May 28, 2021

Tasks done in this PR

  • Issue IKImage not rendering after upload using Hooks #36 fixed
  • Added test cases for IKContext, IKImage, and IKUpload component, where props change should change url accordingly
  • Updated sample app to include a case which updates state through props
  • test-app created in samples/ folder for e2e testing
  • Cypress e2e test cases

Acceptance criteria

  • unit tests should pass npm run test:ci
  • e2e tests should pass npm run test:e2e
  • All Image components should render in the sample app and the button Click to apply radius should apply a radius to the above image, last upload button should render the uploaded image after a successful upload

samples/sample-app/src/App.js Show resolved Hide resolved
samples/test-app/README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #40 (bfc2c76) into master (d2d77d9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bfc2c76 differs from pull request most recent head 81b8b0e. Consider uploading reports for the commit 81b8b0e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          139       150   +11     
  Branches        37        39    +2     
=========================================
+ Hits           139       150   +11     
Impacted Files Coverage Δ
src/components/IKImage/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d77d9...81b8b0e. Read the comment docs.

@nikniv nikniv changed the base branch from master to multiple/e2e-ikimage-bugfix June 3, 2021 12:17
@nikniv nikniv merged commit ac3241d into imagekit-developer:multiple/e2e-ikimage-bugfix Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants