-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin options handling #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely |
Done. There's also a useful side effect: now each plugin is loaded once. Вefore:
After:
|
antongolub
force-pushed
the
master
branch
2 times, most recently
from
August 12, 2019 08:47
c1e1a58
to
a07bff6
Compare
@sindresorhus, any objections / suggestions? |
@sindresorhus, is this good enough to be merged eventually? ) |
3 tasks
sindresorhus
force-pushed
the
master
branch
from
September 26, 2019 09:37
10f34bc
to
e176546
Compare
This reverts commit 10f34bc.
Eagerly awaiting this merge 🙏 |
Thanks, @antongolub 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
I'd like to add optional plugin configuration. There are a couple of solutions:
Which looks better?