CMake refactor #928
Merged
CMake refactor #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the "official" FindOpenImageIO.cmake from OIIO (recently added). This necessitates some renaming, for example standard use of OPENIMAGEIO_ROOT_DIR. * Change inconsistent naming of OSLHOME (and OSL_HOME) to the more standard OSL_ROOT_DIR. * Copy updated FindOpenEXR.cmake from recent OIIO (and related changes). * Eliminate all of testsuite/MaterialX, which was not used, never fully worked, and was certainly out of date with our MX support. If we want to add unit tests for MX shaders, I think I will take a completely different approach. So for now, just eliminate the clutter. * Eliminate site/pixar/Makefile-bits, which they say they no longer use (some of those customizations were the very last uses of some weird custom stuff in our older FindOpenEXR.cmake, now eliminated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the "official" FindOpenImageIO.cmake from OIIO (recently
added). This necessitates some renaming, for example standard use of
OPENIMAGEIO_ROOT_DIR.
Change inconsistent naming of OSLHOME (and OSL_HOME) to the more
standard OSL_ROOT_DIR.
Copy updated FindOpenEXR.cmake from recent OIIO (and related changes).
Eliminate all of testsuite/MaterialX, which was not used, never fully
worked, and was certainly out of date with our MX support. If we want
to add unit tests for MX shaders, I think I will take a completely
different approach. So for now, just eliminate the clutter.
Eliminate site/pixar/Makefile-bits, which they say they no longer use
(some of those customizations were the very last uses of some weird
custom stuff in our older FindOpenEXR.cmake, now eliminated).