testoptix enhancements to make more analogous to testrender #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change -r to -res to match testrender (and for that matter, make -res work for testshade, not -g). (In both cases, the old oddballs are silent synonyms.) * Respond to several additional OSL options, and set them the same was as testrender * Allow --iters (much like it works in testshade) to make it easy to run all the rays many times to make accurate timing easier. Also do a little bit of synchronizing of near-identical code between testshade, testrender, and testoptix. And synchronize some of the analogous command line arguments (e.g., -res for everybody, not -res for testrender and -r for testoptix and -g for testsahde).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change -r to -res to match testrender (and for that matter, make -res
work for testshade, not -g). (In both cases, the old oddballs are
silent synonyms.)
Respond to several additional OSL options, and set them the same
was as testrender
Allow --iters (much like it works in testshade) to make it easy to
run all the rays many times to make accurate timing easier.
Do some of synchronizing of near-identical code between
testshade, testrender, and testoptix. And synchronize some of the
analogous command line arguments (e.g., -res for everybody, not -res
for testrender and -r for testoptix and -g for testsahde).
Add empty
OPTIMIZEONLYmarker files in the optix test directoriesto signify that they don't need -O0 test cases run (currently, such tests
will fail due to the OptiX path not yet supporting "init ops").