improve Idol#find_by_name

[gomao9]

example:

[1] pry(main)> require 'rubimas'
=> true
[2] pry(main)> Rubimas.find_by_name("美也").color
=> "#d7a96b"

[treby]

Thank you for your pr! It's a good idea for extend method. I have few advices.

[treby]

How about the code below? I think we can decrease code volume.

all_idols.find do |idol|
  [idol.key, idol.name.given, idol.name.aka, idol.name.full].include?(idol_name) || raise("unknown idol: #{idol_name}")
end

or we can extend Idol::Name#== method like below

def ==(other)
  super || [aka, family, full].compact.include?(other)
end

and can write find_by_name method like this.

all_idols.find { |idol| [idol.key, idol.name].include? idol_name } || raise("unknown idol: #{idol_name}")

How do you think?

[gomao9]

I think the second idea is better. I'll try it.

[treby]

please remove space: [ " -> ["

[gomao9]

thanks for pointing out. I'll fix it.

[treby]

thanks!