Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile navigation menu select has its last option selected by default #950

Closed
floydpink opened this issue Jan 17, 2013 · 11 comments
Closed

Mobile navigation menu select has its last option selected by default #950

floydpink opened this issue Jan 17, 2013 · 11 comments
Labels
browser bug
Milestone
3.0

Comments

@floydpink
Copy link
Contributor

Rather than Navigate…, the last option in the mobile navigation select (typically » RSS) is the one that is getting as the default.
@floydpink floydpink mentioned this issue Jan 17, 2013
Closed
@parkr
Copy link
Collaborator

parkr commented Feb 13, 2013

My site uses the current master and it seems fine:

my site's nav bar

@parkr
Copy link
Collaborator

parkr commented Feb 13, 2013

Closing: can't replicate.

@parkr parkr closed this as completed Feb 13, 2013
@floydpink
Copy link
Contributor Author

For whatever reason, I still need that one line to get Navigate... as the default on my mobile menu. Anyways...

@parkr
Copy link
Collaborator

parkr commented Feb 13, 2013

What phone/browser are you using?

@floydpink
Copy link
Contributor Author

I did not publish the version out onto the web, so couldn't view it from a real mobile browser. Chrome on my Windows laptop (with Web Developer plugin with View Responsive Layouts option) is where I confirmed it doesn't work (with rake preview to localhost:4000).

Here are the links (one and two) to the sites where I had the issue. (They are both corrected now, but I am still relying on that one line fix)

@parkr
Copy link
Collaborator

parkr commented Feb 13, 2013

Pro tip: If you and your mobile device are connected to the same WiFi network, the mobile device can access the WEBrick server. Ex: http://Parkers-Macbook-Air.local:4000 or if you get the local IP, 192.168.0.108:4000 on your mobile device.

:)

@floydpink
Copy link
Contributor Author

Ah! I know it and have used it a few time, but had forgotten completely from within the octopress previewing context!

Here is the manifestation of the issue:

@parkr
Copy link
Collaborator

parkr commented Feb 13, 2013

So weird! Again, I can't replicate that, even in Chrome for iOS.

I think I might just accept your change because it won't do anything but help this edge case - it shouldn't damage anything on our side.

@parkr parkr reopened this Feb 13, 2013
@marcliberatore
Copy link

For what it's worth, I'm seeing the same problem, and was only able to fix it with the one-liner that I think you've re-opened for.

@floydpink
Copy link
Contributor Author

@parkr: Sounds good. Also, two more fellow octopress-hackers (@marcliberatore, above & @jtwalters, here) seems to have the issue as well.

So time permitting, please apply 7b53014 to both master and 2.1. 👍

@parkr parkr closed this as completed in 43751b7 Feb 15, 2013
parkr pushed a commit that referenced this issue Feb 15, 2013
@floydpink @parkr
Fixed issue with mobile nav choosing the last option by default. Fixes …
f674b8e 
…#950.
@parkr
Copy link
Collaborator

parkr commented Feb 15, 2013

@floydpink Merged into 2.1 and master. Cheers!

jhwist pushed a commit to jhwist/octopress that referenced this issue Feb 25, 2013
@floydpink @jhwist
Fixed issue with mobile nav choosing the last option by default. Fixes …
4b1fa10 
…imathis#950.
paxswill added a commit to paxswill/StupidRobots that referenced this issue Mar 29, 2013
@paxswill
Merge branch 'master' of git://github.com/imathis/octopress
21d22bb 
* 'master' of git://github.com/imathis/octopress: (51 commits)
  fixed addSidebarToggler where index and section were flip-flopped
  Added sass-globbing, allowing plugin stylesheets to be auto-imported from the assets/stylesheets/plugins directory
  Improved: config_tag plugin is much more flexible now and can be used by other plugins directly through the config_tag method
  added config_tag plugin for integration of configuration into templates
  Fixed GitHub jsonp call. Closed imathis#1118
  removed Twitter configuration for timeline and follow buton which are no longer integrated
  Mobile nav fixed.
  Removed Twitter and Ender.js. Added jQuery and updated Modernizr
  Added .gitattributes file to keep CRLF's out of the codebase.
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. imathis#438
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. imathis#438
  Bump sinatra to 1.3.5
  It's 2013. Hi, MIT License.
  Use HTML5 '&' character to connect query params in GitHub API call. imathis#1031.
  Use the Github API repo sorting.
  Fixed issue with mobile nav choosing the last option by default. Fixes imathis#950.
  fixed issue imathis#949 using @alexkirmse's patch
  Update plugins/pygments_code.rb
  Async load of Facebook JS
  Update plugins/pygments_code.rb
  ...

Conflicts:
	Rakefile
	_config.yml
briansimmons pushed a commit to briansimmons/octopress that referenced this issue Aug 20, 2013
@floydpink @parkr
Fixed issue with mobile nav choosing the last option by default. Fixes …
00946a8 
…imathis#950.
lehrblogger pushed a commit to lehrblogger/lehrblogger.com-old that referenced this issue Feb 24, 2014
@floydpink @parkr
Fixed issue with mobile nav choosing the last option by default. Fixes …
ba6ab35 
…imathis#950.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser bug
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@floydpink @parkr @marcliberatore