New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect fake extension requests that don't have a querystring #8

Closed
lilith opened this Issue Jul 17, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@lilith
Member

lilith commented Jul 17, 2012

IIS6 and Classic Pipeline users often use the .ashx fake extension to enable resizing:

I.e, image.jpg.ashx?width=100

However, if the querystring is dropped, the request 404s because ImaegResizer isn't handling it.

image.jpg.ashx -> 404.

A more user-friendly behavior would be to 301 redirect to image.jpg in this situation. However, this should only happen if there are NO querystring values, since a typo would result in redirect frustration.

@lilith

This comment has been minimized.

Show comment
Hide comment
@lilith

lilith Nov 11, 2014

Member

Rewriting would offer a path to circumvent other middleware filters, such as the UrlAuthorizationModule. Classic pipeline usage persists, but is not as prevalent.

Usage in integrated mode often happens due to conflicts with CMSes or other middleware for the standard static file extensions. Usage is unlikely to decline significantly.

Member

lilith commented Nov 11, 2014

Rewriting would offer a path to circumvent other middleware filters, such as the UrlAuthorizationModule. Classic pipeline usage persists, but is not as prevalent.

Usage in integrated mode often happens due to conflicts with CMSes or other middleware for the standard static file extensions. Usage is unlikely to decline significantly.

@lilith lilith added the ready label Nov 23, 2014

@lilith lilith modified the milestones: V4, V4 preview May 4, 2015

lilith added a commit that referenced this issue May 12, 2015

Major core changes: Assign StaticFileHandler for all VPP-only requests (
Fixes #140). Apply .Rewrite changes to all (existing) image requests (fixes fake extension issue #8 and #113). Call ImageMissing for *all* image 404, not just those processed.

@lilith lilith closed this May 12, 2015

@lilith lilith removed the ready label May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment