Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importance calculation takes too much memory and time #2

Closed
mbq opened this issue Sep 11, 2015 · 2 comments
Closed

Importance calculation takes too much memory and time #2

mbq opened this issue Sep 11, 2015 · 2 comments

Comments

@mbq
Copy link

mbq commented Sep 11, 2015

Computing importance (all kinds) in ranger involves first creating a numTrees x numFeatures matrix (made of variable_importance vectors in each tree object), and then averaging it by row, which has a substantial impact on memory use and speed for large numTrees; ranger should just accumulate those values in place, thus using at most numFeatures x numThreads memory.
mnwright pushed a commit that referenced this issue Oct 12, 2015
sum importance values in-place per thread (issue #2)
f543257
mnwright pushed a commit that referenced this issue Oct 12, 2015
sum Gini importance values in-place per thread (issue #2)
1693bad
mnwright added a commit that referenced this issue Oct 12, 2015
@mnwright
Merge pull request #13 from mnwright/importance_memory
062a50e 
Fix issue #2
@mnwright
Copy link
Member

Done. Thanks.

@mbq
Copy link
Author

mbq commented Oct 12, 2015

Great, thanks.

mnwright pushed a commit that referenced this issue May 26, 2016
Merge pull request #2 from animusnaturae/structured_tests
7ac7936 
structured tests
mnwright pushed a commit to rcannood/ranger that referenced this issue Oct 23, 2019
sum importance values in-place per thread (issue imbs-hl#2)
f15a1e1
mnwright pushed a commit to rcannood/ranger that referenced this issue Oct 23, 2019
sum Gini importance values in-place per thread (issue imbs-hl#2)
8332487
mnwright added a commit to rcannood/ranger that referenced this issue Oct 23, 2019
@mnwright
Merge pull request imbs-hl#13 from mnwright/importance_memory
f1a0511 
Fix issue imbs-hl#2
mnwright pushed a commit to rcannood/ranger that referenced this issue Oct 23, 2019
Merge pull request imbs-hl#2 from animusnaturae/structured_tests
fbdaab5 
structured tests
@dougedmunds dougedmunds mentioned this issue Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbq @mnwright