Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RNG to PCG64 #688

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Change RNG to PCG64 #688

wants to merge 8 commits into from

Conversation

mnwright
Copy link
Member

As noted in #414, another random number generator (RNG) might be better than std::mt19937_64. Here, we switch to PCG.

TODOs:

  • Check whether this is faster (or slower)
  • Check reproducibility: Looking at the tests on Github actions, this won't fix the different results on Mac (Results are different between on Mac and on Windows #533).
  • Double check license issue. I think, including it as such is fine.
  • Are there any other side effects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant