Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tell which columns have missing data #89

Merged
merged 1 commit into from
Aug 23, 2016
Merged

tell which columns have missing data #89

merged 1 commit into from
Aug 23, 2016

Conversation

kirillseva
Copy link
Contributor

because it's hard to tell due to non-trivial munging within predict function body

@kirillseva
tell which columns have missing data
f1b3772 
because it's hard to tell due to non-trivial munging within predict function body
@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 86.946% when pulling f1b3772 on kirillseva:better_error into 0a27cc1 on imbs-hl:master.

@mnwright mnwright mentioned this pull request Jul 30, 2016
Closed
mnwright pushed a commit that referenced this pull request Aug 22, 2016
Better missing value check, includes #89
45c26f0
mnwright added a commit that referenced this pull request Aug 22, 2016
@mnwright
Merge pull request #109 from imbs-hl/na_checks
f23f2c9 
Better missing value check, includes #89
@mnwright
Copy link
Member

Thanks! Included in #109.

@mnwright mnwright closed this Aug 22, 2016
@kirillseva
Copy link
Contributor Author

@mnwright it's nice to give people credit for their OSS work to encourage further contributions

@mnwright mnwright reopened this Aug 23, 2016
@mnwright mnwright changed the base branch from master to na_checks August 23, 2016 05:43
@mnwright mnwright merged commit f1b3772 into imbs-hl:na_checks Aug 23, 2016
@mnwright
Copy link
Member

You're right. I've included your PR.

mnwright pushed a commit to rcannood/ranger that referenced this pull request Oct 23, 2019
Better missing value check, includes imbs-hl#89
bd5f4df
mnwright added a commit to rcannood/ranger that referenced this pull request Oct 23, 2019
@mnwright
Merge pull request imbs-hl#109 from imbs-hl/na_checks
08f1a3c 
Better missing value check, includes imbs-hl#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirillseva @coveralls @mnwright