-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update library autoloading to psr-4 #102
Conversation
Config
Code RefactoringDocumentation
Styles
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only comment I have is that a lot of the spacing clean up here seems duplicated from #96.
I'm going to rebase next
onto main
(now that the aforementioned PR is merged) so that should hopefully reduce any replications in this PR.
d7e70dd
to
0c9b3d6
Compare
Resolved merge conflicts, waiting on CI to do its thing. |
Description
Move from PSR-0 to PSR-4 autoloading
This PR changes autoloading from using PSR-0 to PSR-4. PSR-4 is used by basically all modern PHP projects. Main difference is project file/directory structure.
All source and test files have been moved. Namespace has been added to the tests as well.
PSR-0 has been deprecated since 2014, and PSR-4 is recommended as replacement.
Read more on Stack Overflow
I've also removed the custom autoloader found in
src/
, since Composer always includes one. If not using Composer you can always manuallyinclude/require
the files since they're so few.Add config file for PHPUnit
Added
phpunit.xml
config file to repo root, sovendor/bin/phpunit
can be called without duplicating arguments everywhere.Checklist