Fix Python 2/3 compatibility issues #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sherwinski
suggested changes
Mar 11, 2020
There was a problem hiding this comment.
Hey @jnak, thank you very much for the PR!
I appreciate the thoughtfulness you put into this both in regards to test coverage as well as documentation. I only have one small question before moving forward.
|
@sherwinski Thanks for reviewing! |
sherwinski
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
The issue was that
compat.pydid not handle correctly all the edge cases aroundurllib. In addition to aliasing sub-modules,futurebackports someurllibsub-modules so it can better deal with mixed encodings.I had to refactor how the tests are setup in order to run them with and without the compatibility aliases. Due to how
pytestshare environments across tests, it was not possible to conditionally install the aliases on a per-test basis. Now all the tests, except for Flake8, will run in both regular and compatibility modes. This should prevent future regressions.Let me know if you have any questions.