Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate @imgix/js-core into react-imgix #780

Merged
merged 8 commits into from
Apr 22, 2021
Merged

feat: integrate @imgix/js-core into react-imgix #780

merged 8 commits into from
Apr 22, 2021

Conversation

ericdeansanchez
Copy link
Contributor

@ericdeansanchez ericdeansanchez commented Apr 14, 2021 •
edited
Loading

The purpose of this PR is to integrate @imgix/js-core into
react-imgix. First, targetWidths has been reimplemented in terms of
the js-core client. Second, buildSrc has been implemented in terms of
ImgixClient.buildSrcSet. Lastly, a bug fix was made for the
Background component.

Closes #763

@ericdeansanchez ericdeansanchez requested a review from a team as a code owner April 14, 2021 00:36
@commit-lint
Copy link

commit-lint bot commented Apr 14, 2021 •
edited
Loading

Build System

  • add @imgix/js-core as a dependency (736e634)

Features

  • impl targetWidths in terms of ImgixClient.targetWidths() (9e853f4)
  • impl buildSrcSet in terms of @imgix/js-core (992372b)

Bug Fixes

Code Refactoring

Contributors

ericdeansanchez

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@ericdeansanchez ericdeansanchez mentioned this pull request Apr 14, 2021
Closed
@ericdeansanchez

This comment has been minimized.

Sign in to view
frederickfogerty
frederickfogerty reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore, I mistakenly hit submit

frederickfogerty
frederickfogerty approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty great! This is clean ✨ 👏

src/constructUrl.js Show resolved Hide resolved
src/constructUrl.js Show resolved Hide resolved
src/react-imgix.jsx Outdated Show resolved Hide resolved
src/react-imgix.jsx Show resolved Hide resolved
@ericdeansanchez ericdeansanchez merged commit 690e7b6 into main Apr 22, 2021
@ericdeansanchez ericdeansanchez deleted the e/integration branch April 22, 2021 23:51
imgix-git-robot pushed a commit that referenced this pull request Apr 22, 2021
chore(release): 9.1.0
987dd74 
## [9.1.0](v9.0.4...v9.1.0) (2021-04-22)

### Features

* integrate @imgix/js-core into react-imgix ([#780](#780)) ([690e7b6](690e7b6)), closes [#763](#763)

 [skip ci]
imgix-git-robot pushed a commit that referenced this pull request Apr 23, 2021
chore(release): 9.1.0
0fe4d12 
## [9.1.0](v9.0.4...v9.1.0) (2021-04-23)

### Features

* integrate @imgix/js-core into react-imgix ([#780](#780)) ([690e7b6](690e7b6)), closes [#763](#763)

 [skip ci]
@imgix-git-robot
Copy link

🎉 This PR is included in version 9.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ericdeansanchez added a commit that referenced this pull request Apr 23, 2021
@ericdeansanchez
fix: re-render Background only if a larger image is needed (#782)
53bb104 
* fix(BackgroundImpl): re-render only if a larger image is needed

* refactor: component should update if props or imgixParams change

* chore(release): 9.1.0

## [9.1.0](v9.0.4...v9.1.0) (2021-04-22)

### Features

* integrate @imgix/js-core into react-imgix ([#780](#780)) ([690e7b6](690e7b6)), closes [#763](#763)

 [skip ci]

Co-authored-by: imgix-git-robot <support@imgix.com>
@jperegoy jperegoy mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederickfogerty frederickfogerty frederickfogerty approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Background> generating parameters twice for width and height
3 participants
@ericdeansanchez @imgix-git-robot @frederickfogerty