Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use client directive to index #912

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: add use client directive to index #912

merged 2 commits into from
Aug 2, 2023

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Aug 1, 2023

Description

This PR adds the "use client" directive to the components index file.

Before this PR, consumer who didn't add "use client" in a file or wrapper where <Imgix> was used would see a build error in NextJs 13.

After this PR, consumers no longer see this error, and can use <Imgix>, <Picture>, and <Background> as client components, and, critically, as children of server only components.

Checklist

  • Read the contributing guidelines.
  • Each commit follows the Conventional Commit spec format.
  • Update the readme (if applicable).
  • Update or add any necessary API documentation (if applicable)
  • All existing unit tests are still passing (if applicable).

@luqven luqven self-assigned this Aug 1, 2023
@commit-lint
Copy link

commit-lint bot commented Aug 1, 2023

Features

  • add use client directive to index (97747c5)

Documentation

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@luqven luqven marked this pull request as ready for review August 1, 2023 22:18
@luqven luqven requested a review from a team as a code owner August 1, 2023 22:18
Copy link

@bubble-bub bubble-bub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for walking me through this! lgtm~

@luqven luqven merged commit f72cc61 into next Aug 2, 2023
2 checks passed
@luqven luqven deleted the l/nextjs-use-client branch August 2, 2023 21:00
@imgix-git-robot
Copy link

🎉 This PR is included in version 9.8.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants