feat!: draft vue 3 support #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build SystemChore
Code RefactoringTests
Documentation
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Allows .vue single file components to be imported and used. Since the Global Vue API has been deprecated, this file needs to import the return type of defineComponent for TypeScript to be able to import and use the single file components.
Vue can no longer be imported from `vue`. Instead, we need to create a vue app instance and "install" our components on the app.
@VUE cli-plugin-babel, cli-plugin-e2e-cypress, cli-plugin-eslint, cli-plugin-typescrip, cli-plugin-unit-jest, cli-service, compiler-sfc vue, vue-router, and vuex all need to be updated to support Vue 3.
vue-class-component dependency needed to be updated to 8.0 rc1. This version introduced new decorators, a global Vue instance, and a `prop` method which I tried to use with varying success.
The vue-class-component docs are confusing at this time. This was an attempt to remove this dependency. It was not successful.
This commit reverts the use of `App.use`. The correct `App` instance method to use here is `App.component`.
This commit addresses a typo in `buildSrcSet.vue` that resulted in an error where `advancedSrc` was not defined in the scope of the component. It also adds an `alt` attribute to the component, since the vue linter was complaining about it missing.
Global Vue is not available in Vue 3. This commit imports the new `createApp` method and uses it to initialize the vue app.
`testing.imgix` source has been disabled. This commit changes the urls to be `assets.imgix` in the tests that used the old url.
This commit reverts a change where vue-class-component was removed. Instead, it makes proper use of the `prop` and `Vue` exports from that library.
|
This PR has been broken up into several PRs. Closing it. Feel free to pull this down to play with things but it will become stale soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TTSIA
Notable changes
vue-class-componentrefactored to use rc1 APIvue-class-componentrc1Discussion
This PR does not achieve 100% vue 3 compat. It does update most of the dependencies to a compatible version.
There's definitely too many commits in one PR. Working on breaking these up, but for the moment figured some visibility on the proposed changes would be best.This PR has been broken up into several PRs.
Future work
advanced-attribute-configcomponent does not render.Useful reading
Theres some information on the state of Vue 3 support in the community in this issue.