Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove vue-3 compat build #433

Merged
merged 3 commits into from
Jan 12, 2022
Merged

chore: remove vue-3 compat build #433

merged 3 commits into from
Jan 12, 2022

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Jan 12, 2022 •
edited
Loading

Changes

  • removes @vue/compat version and replaces with with "vue": "^3.2.26"
  • updates the vue-cli deps to the latest stable version for use with Vue 3
  • ensures the jest config transforms .vue files using @vue/vue3-jest

@luqven luqven added the @next Preview branch related issue label Jan 12, 2022
@luqven luqven self-assigned this Jan 12, 2022
@commit-lint
Copy link

commit-lint bot commented Jan 12, 2022 •
edited
Loading

Chore

  • remove vue-3 compat build (eb8b1c9)
  • dev-deps: update vue-cli deps (40f92c9)
  • dev-deps: use vue3-jest and jest 27 (b41974e)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

luqven and others added 2 commits January 12, 2022 10:52
@luqven
chore: remove vue-3 compat build
eb8b1c9 
BREAKING CHANGE: Vue 2 syntax and usage no longer compatible
@luqven @frederickfogerty
chore(dev-deps): update vue-cli deps
40f92c9 
This commit updates the vue-cli deps to the latest stable version for
use with Vue 3.

This commit also ensures the jest config transforms `.vue` files using
`vue-jest`.

Co-Authored-By: Frederick Fogerty <frederick.fogerty@gmail.com>
@luqven luqven mentioned this pull request Jan 12, 2022
Closed
17 tasks
@luqven
chore(dev-deps): use vue3-jest and jest 27
b41974e 
This commit fixes an issue where `ts-jest` and `vue-jest` had incorrect
peer deps and at times couldn't be resolved correctly.
@luqven luqven marked this pull request as ready for review January 12, 2022 17:06
@luqven luqven requested a review from a team as a code owner January 12, 2022 17:06
sherwinski
sherwinski approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luqven luqven merged commit 0ecf521 into next Jan 12, 2022
@luqven luqven deleted the l/remove-compat-build branch January 12, 2022 17:52
@imgix-git-robot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherwinski sherwinski sherwinski approved these changes

Assignees

@luqven luqven

Labels
@next Preview branch related issue released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luqven @imgix-git-robot @sherwinski