build: use babel and create cjs bundle #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqven
commented
May 11, 2022
Comment on lines
+17
to
+24
| "files": [ | ||
| "/dist", | ||
| "/src", | ||
| "README.md", | ||
| "CHANGELOG.md", | ||
| "LICENSE", | ||
| "custom-elements.json" | ||
| ], |
There was a problem hiding this comment.
Only include relevant files in package, IE "ignore" tests/ etc.
luqven
commented
May 11, 2022
Comment on lines
+17
to
+19
| const devMode = process.env.NODE_ENV === 'development'; | ||
| console.log(`${devMode ? 'development' : 'production'} mode bundle`); | ||
|
|
There was a problem hiding this comment.
very basic logging for NODE_ENV. It makes it easier to tell which type of bundle is being served during development.
gmp
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.cjsbundle for users who need CJS compact.