Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentService - save method should not detach #220

Closed
rsoika opened this issue Oct 24, 2016 · 1 comment
Closed

DocumentService - save method should not detach #220

rsoika opened this issue Oct 24, 2016 · 1 comment
Labels
bug critical duplicate testing
Milestone
4.0.1

Comments

@rsoika
Copy link
Member

rsoika commented Oct 24, 2016

The save method of the DocumentService can be simplified with the new JPA model.
It is no longer correct to detach the persisted version of the Document entity.
To support correct behavior during multiple save methods on one transaction (e.g. Marty DMSPlugin with FollowUp Events) we may not detach the entity.
But the flush() call is needed to return the next new $version of the document.
@rsoika rsoika added this to the 4.0.1 milestone Oct 24, 2016
rsoika added a commit that referenced this issue Oct 24, 2016
@rsoika
issue #220
496fbef
@rsoika rsoika added the testing label Oct 24, 2016
rsoika added a commit that referenced this issue Oct 24, 2016
@rsoika
issue #220
b75d814
rsoika added a commit that referenced this issue Oct 25, 2016
@rsoika
issue #220
c5d3668
@rsoika
Copy link
Member Author

rsoika commented Nov 5, 2016

Fixed by issue #226

@rsoika rsoika closed this as completed Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical duplicate testing
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
1 participant
@rsoika