Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected OS: Linux #9

Closed
lihop opened this issue May 9, 2023 · 1 comment · Fixed by #10
Closed

Unexpected OS: Linux #9

lihop opened this issue May 9, 2023 · 1 comment · Fixed by #10

Comments

@lihop
Copy link
Contributor

lihop commented May 9, 2023

Thank you for porting this incredibly useful plugin to Godot 4. When I run the Godot 4 version on Linux, I get the error "Unexpected OS: Linux".

Comparing the 3.5 docs to the 4.0 docs shows that the OS.get_name() values for the Unix-like OSes have changed from "OSX", "X11", "Server" to "macOS", "Linux", "FreeBSD", "NetBSD", "OpenBSD", "BSD".

Updating these names in the following line resolves the issue.

gd-plug/addons/gd-plug/plug.gd

Line 709 in b4ac59b

"X11", "OSX", "Server":

lihop added a commit to lihop/gd-plug that referenced this issue May 9, 2023
@lihop
Update the names for Unix-like OSes
4888fc3 
Fixes imjp94#9.
@lihop lihop mentioned this issue May 9, 2023
Merged
@imjp94
Copy link
Owner

imjp94 commented May 9, 2023

déjàvu

@imjp94 imjp94 closed this as completed in #10 May 9, 2023
imjp94 pushed a commit that referenced this issue May 9, 2023
@lihop @imjp94
Update the names for Unix-like OSes
66dcce6 
Fixes #9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the names for Unix-like OSes lihop/gd-plug
2 participants
@lihop @imjp94