Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tosa argmax operation #291

Merged
merged 3 commits into from
May 2, 2022
Merged

Conversation

simon-camp
Copy link
Member

@simon-camp simon-camp commented Apr 27, 2022

Fixes #291.

test/Conversion/tosa-to-emitc.mlir Outdated Show resolved Hide resolved
@simon-camp simon-camp marked this pull request as ready for review April 27, 2022 14:44
@marbre marbre requested review from marbre and removed request for marbre April 27, 2022 15:14
@simon-camp simon-camp force-pushed the tosa-argmax branch 2 times, most recently from 1d169f2 to b4376e4 Compare April 28, 2022 06:39
@marbre
Copy link
Contributor

marbre commented Apr 29, 2022

@dajuro and @heidebro can one of you explicitly look at the function? I only had a look to the mechanics.

@simon-camp please also add a note to https://github.com/iml130/mlir-emitc/blob/main/docs/tosa-op-coverage.md :)

@marbre marbre merged commit 9496a4e into iml130:main May 2, 2022
@simon-camp simon-camp deleted the tosa-argmax branch May 2, 2022 13:29
@marbre
Copy link
Contributor

marbre commented May 2, 2022

Fixes #291.

Should have been #279. #291 links to this merge request 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants