Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support immer ^4.x.x #33

Closed
JustFly1984 opened this issue Sep 15, 2019 · 8 comments
Closed

Support immer ^4.x.x #33

JustFly1984 opened this issue Sep 15, 2019 · 8 comments

Comments

@JustFly1984
Copy link

I see errors while updating my project since I've updated immer to 4.0.0
although everything works without issues

Thank you for your work!

@mweststrate
Copy link
Collaborator

mweststrate commented Sep 16, 2019 via email

@JustFly1984
Copy link
Author

please update your peer dependencies to "immer": "^4.0.0"

@danielkcz
Copy link
Contributor

@JustFly1984 Peer dependency is about warning only during Yarn/NPM install. It's up to you update that in your project. If you are annoyed by warning, then submit a PR 😆

@JustFly1984
Copy link
Author

10:07:02 PM: warning " > use-immer@0.3.3" has incorrect peer dependency "immer@^2.0.0 || ^3.0.0".

@danielkcz
Copy link
Contributor

Sorry, but it's fairly silly. You open this issue like some catastrophic errors are happening... 😆

We have so many peer deps warnings in projects that we stopped worrying about those. Most of them are false positive of a wrong system. So it makes me smile every time when someone is concerned by the extra warning 😄

@nappy
Copy link
Contributor

nappy commented Sep 17, 2019

If the author would not be willing to maintain that range, or would be fine with just ignoring the error, why did not he just put an * in the first place? The only thing that is fairly silly here is your arguing. This is a completely legitimate issue.

@mweststrate
Copy link
Collaborator

This is indeed a valid issue, thanks for the PR @nappy !

@mweststrate
Copy link
Collaborator

Should be released as 0.3.3 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants